Daemon and DHT Tests #79
Conversation
llSourcell
commented
Sep 15, 2014
llSourcell
commented
- Created Daemon_Test.go and testing the listener
- A DHT test
| @@ -13,8 +13,13 @@ func TestProviderManager(t *testing.T) { | |||
| a := u.Key("test") | |||
| p.AddProvider(a, &peer.Peer{}) | |||
| resp := p.GetProviders(a) | |||
| resp2 := p.GetLocal() | |||
There was a problem hiding this comment.
I would try to give some semantic significance to the names of the assigned variables.
For example: assuming GetProviders returns a []Peer, resp and resp2 might not be as readable as localPeers and remotePeers
llSourcell
changed the title
|
@whyrusleeping regarding doing some sample commands over this interface, I think as you said near the end of your comment, that those tests belong in core/commands. |
| return &IpfsNode{ | ||
| Config: nil, | ||
| PeerMap: nil, | ||
| Datastore: nil, |
There was a problem hiding this comment.
The Close method should shut down each of the individual subsystems in core. im not quite sure whats going on here
There was a problem hiding this comment.
ah k, need to convert c++ mentality to go
|
I am closing this pull request because because Brian said there are going to be merge conflicts with the DHT so im only going to push daemon related code in another PR |
gx: update go-testutil
