Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gateway): Content-Disposition improvements #7677

Merged
merged 2 commits into from
Oct 2, 2020
Merged

feat(gateway): Content-Disposition improvements #7677

merged 2 commits into from
Oct 2, 2020

Commits on Sep 16, 2020

  1. feat(gateway): ?filename with download=true 

    This implements 'attachment' mode triggered then
?filename parameter is accompanied with &download=true

When Content-Disposition: attachment is detected by a modern browser
it will skip rendering and immediately open the "save as" dialog,
making this useful feature for using IPFS gateway as target of
"Download" links on various websites.

Parameter name was suggested in:
#4177 (comment)
    @lidel
    lidel committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    fd01acd View commit details
    Browse the repository at this point in the history

  2. feat(gateway): Content-Disposition for legacy clients 

    This adds ASCII-only filename for clients that do not implement RFC 5987

Closes #7648
    @lidel
    lidel committed Sep 16, 2020
    Configuration menu
    Copy the full SHA
    19ec5f4 View commit details
    Browse the repository at this point in the history