Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert changes to the user agent #6993

Merged
merged 1 commit into from
Mar 13, 2020
Merged

fix: revert changes to the user agent #6993

merged 1 commit into from
Mar 13, 2020

Conversation

Stebalien
Copy link
Member

Go-ipfs user agents usually look like go-ipfs/VERSION/COMMIT_or_EMPTY. However,
we changed this to /go-ipfs/VERSION(/COMMIT)? on master for a while. This change
reverts this to make parsing the user agent simpler.

Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

test/sharness/t0026-id.sh Outdated Show resolved Hide resolved
@olizilla
Copy link
Member

hmm odd that the docker build fails with

github.com/blang/semver@v3.6.1+incompatible: invalid version: +incompatible suffix not allowed: module contains a go.mod file, so semantic import versioning is required
The command '/bin/sh -c cd $SRC_DIR   && go mod download' returned a non-zero code: 1

but build succeeds.

@Stebalien
Copy link
Member Author

Because that's the only CI that tests macos?

@Stebalien
Copy link
Member Author

Ah, no, it's because upstream messed up.

Go-ipfs user agents usually look like go-ipfs/VERSION/COMMIT_or_EMPTY. However,
we changed this to /go-ipfs/VERSION(/COMMIT)? on master for a while. This change
reverts this to make parsing the user agent simpler.

Co-Authored-By: Oli Evans <oli@tableflip.io>
@Stebalien Stebalien merged commit 6774106 into master Mar 13, 2020
@Stebalien Stebalien deleted the fix/user-agent branch March 13, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants