Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(graphsync): mount the graphsync libp2p protocol #6892

Merged
merged 2 commits into from
Feb 26, 2020
Merged

feat(graphsync): mount the graphsync libp2p protocol #6892

merged 2 commits into from
Feb 26, 2020

Conversation

Stebalien
Copy link
Member

@Stebalien Stebalien commented Feb 12, 2020 •
edited
Loading

This won't fetch files from graphsync but will serve them.

TODO:

  • Add a test. We should connect a light-weight graphsync client to a running IPFS daemon and try to download a DAG.
  • Make the test pass.
  • Check to make sure we get the right output.

fixes #6830

@Stebalien
Copy link
Member Author

Stebalien commented Feb 12, 2020 •
edited
Loading

@hannahhoward

  • Do we need to do anything special to get other formats to work?
  • Do we need to specify any limits to prevent DoS attacks?

Stebalien
Stebalien commented Feb 14, 2020
View reviewed changes
core/node/graphsync.go
network, ipldBridge,
storeutil.LoaderForBlockstore(bs),
storeutil.StorerForBlockstore(bs),
)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hannahhoward LGTY?

@Stebalien
Copy link
Member Author

So, I've added a test. But it fails with "unspecified error".

@Stebalien
Copy link
Member Author

Oddly, gotest is failing but sharness is passing. It looks like sharness isn't actually running the tests, not sure why.

@Stebalien Stebalien force-pushed the feat/graphsync-server branch 2 times, most recently from 8d125ed to e4a1658 Compare February 18, 2020 18:00
@Stebalien
Copy link
Member Author

Ok, that's more like it.

@Stebalien
Copy link
Member Author

Error:

Request Failed - Unknown Reason

dirkmc
dirkmc approved these changes Feb 26, 2020
View reviewed changes
Copy link
Contributor

@dirkmc dirkmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I have the context to understand the mechanics of how to hook up graphsync, but the code looks error free to me 👍

@Stebalien Stebalien mentioned this pull request Feb 26, 2020
Merged
@Stebalien
Copy link
Member Author

(updated the tests to check the output)

@Stebalien Stebalien merged commit a22dc82 into master Feb 26, 2020
@Stebalien Stebalien deleted the feat/graphsync-server branch February 26, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

@dirkmc dirkmc dirkmc approved these changes

@hannahhoward hannahhoward Awaiting requested review from hannahhoward

@aschmahmann aschmahmann Awaiting requested review from aschmahmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IPFS serves files via graphsync
3 participants
@Stebalien @alanshaw @dirkmc