IPNS over PubSub as an Independent Transport #6758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschmahmann
force-pushed
the
feat/ipns-persistent-pubsub
branch
from
5b8e152
to
53fd7d8
Compare
Stebalien
added
the
status/blocked
aschmahmann
force-pushed
the
feat/ipns-persistent-pubsub
branch
2 times, most recently
from
0633640
to
d3949aa
Compare
|
This is also blocked by #6785 since go-libp2p-pubsub-router was updated to use the latest datastore interface. |
Stebalien
removed
the
status/blocked
|
@aschmahmann could you rebase this PR on master (and release the new pubsub router)? I'd like to not block this on the async datastore refactor (IIRC, this is mergable as-is). |
aschmahmann
force-pushed
the
feat/ipns-persistent-pubsub
branch
from
d3949aa
to
d735b28
Compare
aschmahmann
force-pushed
the
feat/ipns-persistent-pubsub
branch
from
d735b28
to
36494e4
Compare
Stebalien
approved these changes
Dec 13, 2019
| if bcfg.getOpt("pubsub") || bcfg.getOpt("ipnsps") { | ||
| disc = fx.Provide(libp2p.TopicDiscovery()) |
There was a problem hiding this comment.
note: we can actually just register this regardless.
|
🕺 |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilizes the persistent pubsub value store from libp2p along with the new pubsub support for topic-based peer discovery.
Blocked by libp2p/go-libp2p-pubsub-router#37