New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(coreapi/add): close the fake repo used when adding with hash-only #6747

Merged

Stebalien merged 1 commit into master from fix/only-hash-leak

Nov 8, 2019

Member

Stebalien commented Nov 4, 2019

fixes #6744


          fix(coreapi/add): close the fake repo used when adding with hash-only

e9e32f8

fixes #6744

github-actions bot requested a review from djdv

November 4, 2019 18:07

Stebalien requested a review from aschmahmann

November 4, 2019 18:08

dirkmc approved these changes

View reviewed changes

Member Author

Stebalien commented Nov 8, 2019

Note: there are actually two issues here:

fix: close peerstore on stop #6629 (fixed).
Closing the node. Technically, this should already mostly happen when the context is canceled. However, it doesn't hurt to explicitly close the node as well.

Stebalien merged commit ec748a7 into master

This was referenced Jan 17, 2020

Release v0.4.23 #6836

Closed

Release v0.4.23 #6837

Closed

hacdias deleted the fix/only-hash-leak branch

May 9, 2023 10:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet