feat: make it easier to load custom plugins #6474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Stebalien
commented
Jun 28, 2019
Stebalien
commented
- Allow loading from arbitrary and multiple directories.
- Make it possible to directly load built-in plugins that aren't in the preload list.
- Check the plugin loading state transitions.
1. Allow loading from arbitrary and multiple directories. 2. Make it possible to directly load built-in plugins that _aren't_ in the preload list.
|
Inspired by ipfs/go-ipfs-config#5 (comment). Loading custom plugins is currently a bit annoying. |
Kubuxu
reviewed
Jun 28, 2019
go.mod
Outdated
| @@ -112,6 +112,7 @@ require ( | |||
| go4.org v0.0.0-20190313082347-94abd6928b1d // indirect | |||
| golang.org/x/sync v0.0.0-20190423024810-112230192c58 // indirect | |||
| golang.org/x/sys v0.0.0-20190626221950-04f50cda93cb | |||
| google.golang.org/appengine v1.4.0 // indirect | |||
There was a problem hiding this comment.
I have no idea why this dep started showing up but it is a heisen-dep, it shows up on build and disappears with tidy.
There was a problem hiding this comment.
Yeah, it's a bug in go and I don't feel like reporting it.
Stebalien
force-pushed
the
feat/builtin-plugin
branch
from
4bbe007
to
a9f7490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.