Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ping: fix a bunch of issues #6312

Merged
merged 6 commits into from
May 9, 2019
Merged

ping: fix a bunch of issues #6312

merged 6 commits into from
May 9, 2019

Commits on May 9, 2019

  1. ping: don't return success on failed pings 

    fixes #6298

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed May 9, 2019
    Configuration menu
    Copy the full SHA
    cab9ddf View commit details
    Browse the repository at this point in the history

  2. ping: compute average latency when interrupted 

    (this should always have been done on the client, IMO, but, oh well...)

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed May 9, 2019
    Configuration menu
    Copy the full SHA
    6a91d14 View commit details
    Browse the repository at this point in the history

  3. ping: return an error on failure 

    Use PingResult errors for errors attached to individual pings.

This is a (minor) BREAKING CHANGE.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed May 9, 2019
    Configuration menu
    Copy the full SHA
    e511b4c View commit details
    Browse the repository at this point in the history

  4. dep: update go-ipfs-cmds 

    (fixes double printing of errors)

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed May 9, 2019
    Configuration menu
    Copy the full SHA
    3c9be59 View commit details
    Browse the repository at this point in the history

  5. ping: cleanup error message 

    License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed May 9, 2019
    Configuration menu
    Copy the full SHA
    6e2858e View commit details
    Browse the repository at this point in the history

  6. ping: fixup sharness tests 

    License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed May 9, 2019
    Configuration menu
    Copy the full SHA
    3803a6e View commit details
    Browse the repository at this point in the history