Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

commands: fix a bunch of tiny commands-lib issues #5697

Merged
merged 1 commit into from
Oct 30, 2018
Merged

commands: fix a bunch of tiny commands-lib issues #5697

merged 1 commit into from
Oct 30, 2018

Commits on Oct 30, 2018

  1. commands: fix a bunch of tiny commands-lib issues 

    * Always check errors returned by emit. Otherwise, we may not notice when the
  client goes away.
* Make sure to use EmitOnce instead of Emit when appropriate. Otherwise, we
  break javascript.

(thanks Magik6k for finding this before we cut the release...)

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
    @Stebalien
    Stebalien committed Oct 30, 2018
    Configuration menu
    Copy the full SHA
    e332af8 View commit details
    Browse the repository at this point in the history