Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for go-ipfs-files refactor #5661

Merged
merged 16 commits into from
Dec 20, 2018
Merged

Update for go-ipfs-files refactor #5661

merged 16 commits into from
Dec 20, 2018

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Oct 26, 2018

@magik6k magik6k requested a review from Kubuxu as a code owner October 26, 2018 16:47
@ghost ghost assigned magik6k Oct 26, 2018
@ghost ghost added the status/in-progress In progress label Oct 26, 2018
@magik6k magik6k force-pushed the gx/files2 branch 2 times, most recently from 7e38d3c to 665019c Compare October 26, 2018 22:08
@magik6k magik6k force-pushed the gx/files2 branch 5 times, most recently from 77270e5 to c14e85c Compare November 6, 2018 00:26
@magik6k magik6k changed the title [WIP] Update for go-ipfs-files refactor Update for go-ipfs-files refactor Nov 6, 2018
@magik6k magik6k added the status/blocked Unable to be worked further until needs are met label Nov 16, 2018
@magik6k
Copy link
Member Author

magik6k commented Nov 16, 2018

Blocked by #5762 which is blocked by #5526

@Stebalien
Copy link
Member

Ok, I'm just going to rebase #5526.

@Stebalien Stebalien removed the status/blocked Unable to be worked further until needs are met label Nov 16, 2018
@magik6k magik6k force-pushed the gx/files2 branch 4 times, most recently from bee0298 to 63116c1 Compare November 24, 2018 03:52
@magik6k magik6k requested a review from kevina November 24, 2018 04:37
@magik6k magik6k force-pushed the gx/files2 branch 5 times, most recently from 724f640 to 6571281 Compare December 1, 2018 00:11
@magik6k magik6k force-pushed the gx/files2 branch 3 times, most recently from 53efd96 to ab2ac69 Compare December 13, 2018 22:30
core/commands/block.go Outdated Show resolved Hide resolved
core/commands/config.go Outdated Show resolved Hide resolved
core/commands/config.go Outdated Show resolved Hide resolved
core/commands/dag/dag.go Outdated Show resolved Hide resolved
core/commands/files.go Outdated Show resolved Hide resolved
core/commands/object/patch.go Outdated Show resolved Hide resolved
core/commands/object/patch.go Outdated Show resolved Hide resolved
core/commands/object/patch.go Outdated Show resolved Hide resolved
core/commands/object/object.go Outdated Show resolved Hide resolved
core/commands/object/object.go Outdated Show resolved Hide resolved
Copy link
Member

@Stebalien Stebalien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor fixes but this looks good otherwise.

core/commands/cmdenv/file.go Show resolved Hide resolved
cmd/ipfs/init.go Show resolved Hide resolved
if err != nil {
return nil, 0, err
}

if file.IsDirectory() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What'll happen if this is a symlink?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we have proper support for them currently anyways. Changed the error to make it less confusing

License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@magik6k
Copy link
Member Author

magik6k commented Dec 20, 2018

@Stebalien rebased, is there anything else blocking this or is it RFM?

@Stebalien Stebalien merged commit daa1202 into master Dec 20, 2018
@ghost ghost removed the status/in-progress In progress label Dec 20, 2018
@Stebalien Stebalien deleted the gx/files2 branch December 20, 2018 15:12
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
Update for go-ipfs-files refactor

This commit was moved from ipfs/kubo@daa1202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants