disable the MacOS tests in jenkins #5119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They've never really been enabled but they: 1. Are causing the tests to fail for various reasons (e.g., out of space). 2. Take time. License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
ghost
assigned 
|
cc @victorbjelkholm ? |
Stebalien
added
need/review
victorb
reviewed
Jun 14, 2018
| try { | ||
| run "make -j12 test/sharness/test-results/sharness.xml CONTINUE_ON_S_FAILURE=1 TEST_NO_FUSE=1" | ||
| } catch (err) { | ||
| throw err |
There was a problem hiding this comment.
Seems just commenting this and line 167 would give the wanted effect, rather than commenting the entire thing. But since @magik6k initially developed it, I'll leave it up to him to decide.
Although, removing the builds fully feels wrong, as we want to make sure it at least runs somewhat on macOS
There was a problem hiding this comment.
It's better to comment out the whole blocks imo
|
Will conflict a bit with #5071 but it's easy fix. (well, other than the fact that we then got some data about failing mac tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They've never really been enabled but they: