Fix wrong added filename #4919
Fix wrong added filename #4919
Conversation
|
I am wondering why no tests have detected it. |
License: MIT Signed-off-by: Masahiro Saito <camelmasa@gmail.com>
|
@Kubuxu Thanks for checking. I just changed test data directory path from Case of original code, Returned value was changed after I just change the directory path. |
| @@ -336,7 +337,10 @@ func AddR(n *core.IpfsNode, root string) (key string, err error) { | |||
| return "", err | |||
| } | |||
|
|
|||
| f, err := files.NewSerialFile(root, root, false, stat) | |||
| segs := strings.Split(root, "/") | |||
| name := segs[len(segs)-1] | |||
There was a problem hiding this comment.
use name := filepath.Base(root) instead of string splitting.
Filepath is aware of system specific separators.
There was a problem hiding this comment.
This probably broke go test on windows - https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fgo-ipfs/detail/PR-4919/4/pipeline
|
Since the author has been gone for ~1mo, can someone else take over this changeset? cc @djdv maybe? |
|
Amended in: #5167 |
I think It looks
files.NewSerialFile's first argument is wrong.Note: The
coreunix.AddRwill be removed after implemented Core API (Ref: #4562).