Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No dev null pipe #4849

Merged
merged 2 commits into from
Mar 23, 2018
Merged

No dev null pipe #4849

merged 2 commits into from
Mar 23, 2018

Conversation

chriscool
Copy link
Contributor

Any IPFS command should accept the --help flag even if /dev/null is not piped to it. Let's properly check that this works.

See #4841 for more context.

@chriscool chriscool requested a review from Kubuxu as a code owner March 20, 2018 21:05
@ghost ghost assigned chriscool Mar 20, 2018
@ghost ghost added the status/in-progress In progress label Mar 20, 2018
@chriscool chriscool mentioned this pull request Mar 20, 2018
Open
@chriscool
Copy link
Contributor Author

The error in Jenkins is:

expecting success: 
  ipfs shutdown
Error: Post http://127.0.0.1:38163/api/v0/shutdown?encoding=json&stream-channels=true: EOFnot ok 14 - shutdown succeeds
#	
#	  ipfs shutdown
#

@chriscool
Copy link
Contributor Author

The error in circle Ci is:

expecting success: 
    test_kill_repeat_10_sec $IPFS_PID
  
not ok 29 - 'ipfs daemon' can be killed
#	
#	    test_kill_repeat_10_sec $IPFS_PID
#

It doesn't look related either.

@chriscool
Copy link
Contributor Author

I don't understand what codecov complains about.

@Stebalien
Copy link
Member

Don't know. Maybe we don't run unit tests when code isn't changed?

@Stebalien Stebalien added RFM and removed status/in-progress In progress labels Mar 20, 2018
@Kubuxu
Copy link
Member

Kubuxu commented Mar 23, 2018

We have some code paths it tests that randomly might not run thus resulting in lower coverage. Pushed #4867

@chriscool
Copy link
Contributor Author

@Kubuxu ok can you merge this PR?

@whyrusleeping
Copy link
Member

Needs a rebase

@chriscool
sharness/t0010: don't pipe /dev/null into $cmd --help tests
1bb3aba 
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@chriscool
sharness/t0010: also check 'echo stuff | $cmd --help'
8a2035e 
License: MIT
Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
@ghost ghost added the status/in-progress In progress label Mar 23, 2018
@chriscool
Copy link
Contributor Author

Rebased.

@Kubuxu Kubuxu removed the status/in-progress In progress label Mar 23, 2018
@whyrusleeping whyrusleeping merged commit 8dbdb29 into master Mar 23, 2018
@whyrusleeping whyrusleeping deleted the no-dev-null-pipe branch March 23, 2018 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stebalien Stebalien Stebalien approved these changes

@Kubuxu Kubuxu Kubuxu approved these changes

Assignees

@chriscool chriscool

Labels
RFM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chriscool @Stebalien @Kubuxu @whyrusleeping