WIP: batch fetching interfaces on dagservice #4314
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Stebalien
reviewed
Oct 18, 2017
| @@ -334,6 +358,7 @@ type nodePromise struct { | |||
| // the first call to Get will block until the Node is received | |||
| // from its internal channels, subsequent calls will return the | |||
| // cached node. | |||
| // TODO: this is a name clash with node.NodeGetter | |||
There was a problem hiding this comment.
I'm removing this interface in ipfs/go-ipld-format#8 (introducing a single, public NodePromise type.
| return nil, ErrReadOnly | ||
| } | ||
|
|
||
| func (r *roDagService) GetLinks(ctx context.Context, c *cid.Cid) ([]*node.Link, error) { |
There was a problem hiding this comment.
This function will also go away wit that PR.
| return node.Links(), nil | ||
| } | ||
|
|
||
| func (r *roDagService) GetOfflineLinkService() LinkService { |
| func (r *roDagService) GetOfflineLinkService() LinkService { | ||
| panic("do not call this method on this object") | ||
| } | ||
| func (r *roDagService) Batch() *Batch { |
unixfs/io/resolve.go
Outdated
| @@ -28,7 +28,8 @@ func ResolveUnixfsOnce(ctx context.Context, ds dag.DAGService, nd node.Node, nam | |||
|
|
|||
| switch upb.GetType() { | |||
| case ft.THAMTShard: | |||
| s, err := hamt.NewHamtFromDag(ds, nd) | |||
| panic("foo") | |||
There was a problem hiding this comment.
We should probably distinguish between a hampt reader and a hampt writer.
whyrusleeping
force-pushed
the
feat/fetcher-interfaces
branch
from
d3ac4b9
to
979280d
Compare
License: MIT Signed-off-by: Jeromy <jeromyj@gmail.com>
whyrusleeping
force-pushed
the
feat/fetcher-interfaces
branch
from
979280d
to
db5b831
Compare
Kubuxu
reviewed
Mar 6, 2018
There was a problem hiding this comment.
@Stebalien I see that ipfs/go-ipld-format#8 introduced NodeGetter with GetMany.
Does this make this PR obsolete?
|
Yes. @whyrusleeping made a follow up PR that uses the new interfaces but we had to revert it as sessions need a bit of work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wip wip wip, definitely looking for feedback on this.
License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com