Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace #3990: blocks: move block format to it's own repo #4023

Merged
merged 4 commits into from
Jul 3, 2017
Merged

Replace #3990: blocks: move block format to it's own repo #4023

merged 4 commits into from
Jul 3, 2017

Conversation

magik6k
Copy link
Member

@magik6k magik6k commented Jun 29, 2017

This continues #3990

@Stebalien @magik6k
blocks: move block format to it's own repo
bccd4d4 
We need to reference it from outside of this repo.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien @magik6k
blocks: gx import go-block-format
13636be 
And updated related dependencies.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien @magik6k
gx import/update libp2p/go-libp2p-routing
520938a 
For some reason, this was referenced but wasn't listed in packages.json.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Kubuxu Kubuxu added the status/in-progress In progress label Jun 29, 2017
@Stebalien
Copy link
Member

Did I miss something? This PR is identical to #3990...

@whyrusleeping
Copy link
Member

@Stebalien yeah, #3990 was on your repo (and not the main go-ipfs one) so we couldnt rebase it on our own. This is just your commits rebased on latest master, we didnt want to bother you asking for a rebase :)

@Stebalien
Copy link
Member

Stebalien commented Jun 29, 2017 via email

@Stebalien Stebalien requested a review from a user June 29, 2017 22:06
@Stebalien
Copy link
Member

Waiting on ipfs/go-ipld-cbor#16

@Stebalien Stebalien mentioned this pull request Jun 30, 2017
Merged
@magik6k
blocks: update go-ipld-cbor
0419e3d 
License: MIT
Signed-off-by: Łukasz Magiera <magik6k@gmail.com>
@Stebalien
Copy link
Member

The current test failure looks unrelated:

test/sharness/t0130-multinode.sh:

expecting success: 
			check_has_connection "$i" ||
			test_fsh cat "swarm_peers_$i"
		(B
> cat swarm_peers_3

not ok 7 - node 3 is connected(B
#	
#				check_has_connection "$i" ||
#				test_fsh cat "swarm_peers_$i"
#

@Kubuxu
Copy link
Member

Kubuxu commented Jul 1, 2017

Yes it is one of unrelated failures we are chasing for a long time.

@whyrusleeping
Copy link
Member

LGTM!

@whyrusleeping whyrusleeping merged commit 7488102 into master Jul 3, 2017
@whyrusleeping whyrusleeping deleted the feat/extract-block branch July 3, 2017 17:04
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Jul 3, 2017
@magik6k magik6k restored the feat/extract-block branch November 27, 2017 03:34
@magik6k magik6k deleted the feat/extract-block branch November 27, 2017 03:47
hacdias pushed a commit to ipfs/boxo that referenced this pull request Jan 27, 2023
@whyrusleeping
Merge pull request ipfs/kubo#4023 from ipfs/feat/extract-block
4209696 
Replace #3990: blocks: move block format to it's own repo

This commit was moved from ipfs/kubo@7488102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@magik6k @Stebalien @whyrusleeping @Kubuxu