Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple performance metrics #3615

Merged
merged 5 commits into from
Mar 2, 2017
Merged

Add multiple performance metrics #3615

merged 5 commits into from
Mar 2, 2017

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Jan 20, 2017 •
edited
Loading

Resolves #3607

@Kubuxu Kubuxu added the status/in-progress In progress label Jan 20, 2017
@whyrusleeping
Copy link
Member

@Kubuxu build failure

@Kubuxu
Copy link
Member Author

Kubuxu commented Jan 22, 2017

@whyrusleeping fixed

@flyingzumwalt
Copy link

Related to today's standup discussion, this PR doesn't add any tests or documentation.

  • It doesn't make it clear how you would get these metrics out of go-ipfs when you run it
  • It doesn't test that the metrics are actually being recorded when you run the code

@whyrusleeping
Copy link
Member

@flyingzumwalt Thanks, mind filing an issue about needing to add tests for metrics?

Since we don't currently have the setup to test metrics in a meaningful way, adding them here is out of scope for this PR as implementing it would be a non-significant endeavor and would take a good hunk of time from our already tight timeline.

@whyrusleeping whyrusleeping added this to the ipfs 0.4.6 milestone Feb 12, 2017
@Kubuxu
Copy link
Member Author

Kubuxu commented Feb 12, 2017

Good after it passes.

@whyrusleeping
Copy link
Member

@Kubuxu OSX sharness failures don't appear to be a fluke.

@Kubuxu
Copy link
Member Author

Kubuxu commented Feb 12, 2017

It is same as: #3677 (comment)

@whyrusleeping
Copy link
Member

@Kubuxu I'm sorry, can you rebase?

@whyrusleeping whyrusleeping modified the milestones: Ipfs 0.4.7, ipfs 0.4.6 Feb 17, 2017
@Kubuxu
cleanup: metrics collection
f588558 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Introduce block and dup histograms to bitswap
26cb182 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
refactor: cleanup bitswap metrics collection
ce684ab 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Add metric of number of elements in the wantlist
ccd1f8e 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Introduce sent blocks histogram
acfaf9a 
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 2, 2017

Rebased

whyrusleeping
whyrusleeping approved these changes Mar 2, 2017
View reviewed changes
Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whyrusleeping whyrusleeping merged commit d373e93 into master Mar 2, 2017
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Mar 2, 2017
@whyrusleeping whyrusleeping deleted the feat/metrics/perf branch March 2, 2017 17:14
@Kubuxu
Copy link
Member Author

Kubuxu commented Mar 2, 2017

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whyrusleeping whyrusleeping whyrusleeping approved these changes

Assignees

@Kubuxu Kubuxu

Labels
None yet
Projects
None yet
Milestone
Ipfs 0.4.7
Development

Successfully merging this pull request may close these issues.
3 participants
@Kubuxu @whyrusleeping @flyingzumwalt