Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

namesys: fix case where there is no cache #3509

Merged
merged 2 commits into from
Dec 16, 2016

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Dec 15, 2016

License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch

@Kubuxu Kubuxu added this to the ipfs 0.4.5 milestone Dec 15, 2016
@Kubuxu Kubuxu added the status/in-progress In progress label Dec 15, 2016
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@whyrusleeping
Copy link
Member

@Kubuxu Tests? i'm not sure what scenario this actually resolves

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Copy link
Member Author

Kubuxu commented Dec 15, 2016

@whyrusleeping
Copy link
Member

For some weird alignment of the stars type reason all the osx tests seem to have failed... for different reasons. Rerunning them to try for better

Copy link
Member

@whyrusleeping whyrusleeping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting on tests

@Kubuxu
Copy link
Member Author

Kubuxu commented Dec 16, 2016

OSX passed on Travis

@whyrusleeping whyrusleeping merged commit f6948bb into master Dec 16, 2016
@whyrusleeping whyrusleeping deleted the fix/namesys/dht-cache-panic branch December 16, 2016 00:41
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Dec 16, 2016
@ghost ghost mentioned this pull request Dec 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants