Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commands Refactor Part 2 - rebased #332

Merged
merged 383 commits into from
Nov 14, 2014
Merged

Commands Refactor Part 2 - rebased #332

merged 383 commits into from
Nov 14, 2014

Conversation

jbenet
Copy link
Member

@jbenet jbenet commented Nov 14, 2014

This supercedes #263

mappum and others added 30 commits November 14, 2014 03:17
@mappum @jbenet
core/commands2: Added 'bootstrap' command
16c584c
@mappum @jbenet
core/commands2: Added 'mount' command
1c5979e
@mappum @jbenet
core/commands2: Added 'block' command
18cce63
@jbenet
fmt
8cc1f67
@jbenet
refactor(core/commands2/add) split loop
e096060 
@mappum
@jbenet
add online method to node
772f657
@jbenet
check mode with use func node.OnlineMode() bool
8b6931c
@jbenet
rename -> OnlineMode()
6d89094 
because this method doesn't check actual network status
@jbenet
refac(commands2/ls) split loop
353cb39 
@mappum
@jbenet
refac(commands2/pin) loop
86f0aac
@jbenet
extract toStrings method
4c029a8
@jbenet
add slice utils
92d20e4 
ToStrings and ToReaders
@jbenet
extract unpin
440c90b 
@mappum
@jbenet
fix(cli) tear down node
084ffd9
@jbenet
fix(add) cast safely
c65b01c
@jbenet
feat(commands2/tour) impl
520240d
@mappum @jbenet
cmd/ipfs2: Set all loggers to DEBUG level when running with 'debug' flag
7ead660
@mappum @jbenet
commands/http: Log incoming requests (with DEBUG log level)
3df5202
@mappum @jbenet
core/commands2: Added 'update' command
36dfb7b
@jbenet
named imports
99d5098
@jbenet
fix(tour) variadic -> false
aa1c3ca
@jbenet
docs(add) help
a631d74
@jbenet
docs(commands) help
1c7ef89
@jbenet
docs(net-diag) help + name
48d65c6 
@jbenet @whyrusleeping

Docs read net-diag. It seems the command was previously registered as
diag. Which do you prefer?
@jbenet
docs(log) help
229b22f 
making docs match command:
        name -> subsystem. Is the desired name?
@jbenet
docs(ls) help
0e8e3cc
@jbenet
todo(ls)
d066f15 
@jbenet
@jbenet
fix(mount) add argument
ff55968
@jbenet
add fixmes
c69ea0d
@jbenet
docs(name/publish/resolve) help
092e346
mappum and others added 18 commits November 14, 2014 03:20
@mappum @jbenet
object get: Fixed protobuf marshaling
537f94a
@mappum @jbenet
object put: Formatted helptext
eb696d9
@mappum @jbenet
object put: Fixed putting objects with JSON encoding
b4de6cc
@mappum @jbenet
object put: Added plaintext marshaler
fceb55e
@mappum @jbenet
object put: Made output (almost) match original output
9d29963 
(The file path is omitted, but since only one object can be added at a time, I think this is ok)
@mappum @jbenet
object data: Moved some helptext into LongDescription
7bd7624
@mappum @jbenet
object links: Added text marshaling
b3da13a
@jbenet
cmds2: mount exmplae
5e598f9
@mappum @jbenet
object links: Fixed description
d056615
@mappum @jbenet
commands/http: Fixed client erroring on nil command output
231960e
@jbenet
cmds2: change add arg name
97d2f48
@mappum @jbenet
commands/cli: Take an optional Stdin value in Parse (read as a reader…
00b19f8 
… argument or string argument)
@mappum @jbenet
main: Pass Stdin to CLI request parser
1abe976
@mappum @jbenet
commands/cli: Fixed bug when parsing args for a command that doesn't …
9370740 
…have any argument definitions
@mappum @jbenet
commands: Added a flag to enable stdin arguments
2b6b6fa
@mappum @jbenet
block put: Support stdin input on 'block put'
e4b6302
@jbenet
cmds2: check for updates
fa8fc1a
@jbenet
cmds: nicer error on no mountpoint
f30161b
@jbenet jbenet added the status/in-progress In progress label Nov 14, 2014
@jbenet jbenet mentioned this pull request Nov 14, 2014
Closed
docs(2/pin)
a0dab3a 
ipfs1 docs read:

```
btc λ. ipfs pin
ipfs pin -

Commands:

        add         pin an ipfs object to local storage.
        rm          unpin an ipfs object from local storage.

        Use "pin help <command>" for more information about a command.
```

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
@jbenet
Copy link
Member Author

jbenet commented Nov 14, 2014

fix(test) tour content struct now exists
ee378e2 
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
jbenet added a commit that referenced this pull request Nov 14, 2014
@jbenet
Merge pull request #332 from jbenet/cmd-ref-part2-rebase
7f31b04 
Commands Refactor Part 2 - rebased
@jbenet jbenet merged commit 7f31b04 into master Nov 14, 2014
@jbenet jbenet removed the status/in-progress In progress label Nov 14, 2014
@jbenet jbenet deleted the cmd-ref-part2-rebase branch November 14, 2014 11:36
@jbenet
Copy link
Member Author

jbenet commented Nov 14, 2014

@btc
Copy link
Contributor

btc commented Nov 14, 2014

bff

ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this pull request Oct 23, 2021
@Stebalien
Merge pull request ipfs#332 from libp2p/fix/reduce-buffer-memory
1449871 
fix: reduce memory used by buffered writers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbenet @btc @mappum