Fixes #3133: Properly handle release candidates in version comparison #3136
Conversation
|
cc @chriscool and @lgierth for review |
mateon1
force-pushed
the
fix/version-comparison
branch
2 times, most recently
from
1d60491
to
544c577
Compare
…ison Deduplicate version checking code across scripts License: MIT Signed-off-by: Mateusz Naściszewski <matin1111@wp.pl>
mateon1
force-pushed
the
fix/version-comparison
branch
from
544c577
to
1667212
Compare
| } | ||
| # Get path to the directory containing this file | ||
| # If $0 has no slashes, uses "./" | ||
| PREFIX=$(expr $0 : "\(.*\/\)") || PREFIX='./' |
There was a problem hiding this comment.
It might be safer to use expr "$0" instead of expr $0 in case $0 contains spaces.
License: MIT Signed-off-by: Mateusz Naściszewski <matin1111@wp.pl>
| major_number() { | ||
| vers="$1" | ||
|
|
||
| # Hack around 'expr' exiting with code 1 when it outputs 0 |
There was a problem hiding this comment.
wat. Thats dumb. (I just ran this in my shell)
There was a problem hiding this comment.
I agree, but that's from the original version checking code by chriscool.
The same goes for an empty string as output, hence the digit captured in both regex alternations at lines 39/52.
There was a problem hiding this comment.
@whyrusleeping and @mateon1 I am not sure what you think is dump.
My opinion is that expr exiting with code 1 when it returns 0 is really dump indeed!
It looks like it comes from the fact that it can be used for arithmetics.
|
@chriscool Look good to you? |
|
@whyrusleeping yeah LGTM now! |
|
Thanks @mateon1! |
ghost
mentioned this pull request
License: MIT
Signed-off-by: Mateusz Naściszewski matin1111@wp.pl