remove randbo dep, its no longer needed #3118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests failing because CI uses go1.5, the rand reader stuff landed in 1.6 |
whyrusleeping
added
the
status/blocked
| @@ -552,7 +551,8 @@ func actorMakeFile(d *Directory) error { | |||
| return err | |||
| } | |||
|
|
|||
| r := io.LimitReader(randbo.New(), int64(77*rand.Intn(123))) | |||
| rread := rand.New(rand.NewSource(time.Now().UnixNano())) | |||
There was a problem hiding this comment.
we have NewTimeSeededRand in go-ipfs-util.
There was a problem hiding this comment.
if we already import from there, then sure, lets use it. Otherwise i'd like to avoid another import of that package. I want it to die.
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
whyrusleeping
force-pushed
the
deps/rm-randbo
branch
from
d1de49c
to
3b3f2d8
Compare
whyrusleeping
removed
status/blocked
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to continue doing things like this as we find deps are no longer needed. A smaller dependency tree is a happier one
License: MIT
Signed-off-by: Jeromy why@ipfs.io