Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework stdin handling #2952

Merged
merged 10 commits into from
Jul 16, 2016
Merged

rework stdin handling #2952

merged 10 commits into from
Jul 16, 2016

Conversation

whyrusleeping
Copy link
Member

no comment

License: MIT
Signed-off-by: Jeromy why@ipfs.io

@whyrusleeping
starting to rework stdin handling
96433cc 
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping
Copy link
Member Author

cc @jbenet @Kubuxu @lgierth

@whyrusleeping
clean up previous work a bit
a6af6c5 
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping
ignore those last bits, this time its for real
1aeda7e 
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping
docs
467eb8d 
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping
cleanup
cd46743 
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping
re-enable the stdin
5d301cb 
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping
and special case that one thing because why not
b034a0d 
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping
Copy link
Member Author

Alright, this should be ready for review. cc @jbenet @Kubuxu @thomas-gardner

@whyrusleeping
add bootstrap add-default and rm-all subcommands to deprecate flags
1f6dd26 
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
Kubuxu
Kubuxu reviewed Jul 9, 2016
View reviewed changes
commands/cli/parse.go
// stdinSpecialName is a name applied to the 'stdin' file so we can differentiate
// it from potential 'real' files being passed in. The '*' character is invalid in
// path names and won't appear otherwise.
const stdinSpecialName = "*stdin*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

* is valid in path names.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

 ../test/sharness   patch-1  echo Yes it works > '*stdin*'
 ../test/sharness   patch-1 ?  cat '*stdin*'
Yes it works

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

youre right, and this is no longer needed.

@whyrusleeping
remove badcode
c142534 
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping
a little more cleanup
9ff238e 
License: MIT
Signed-off-by: Jeromy <why@ipfs.io>
@whyrusleeping whyrusleeping changed the title starting to rework stdin handling rework stdin handling Jul 15, 2016
@whyrusleeping whyrusleeping merged commit 676b5ee into master Jul 16, 2016
@whyrusleeping whyrusleeping deleted the fix/stdin-handling branch July 16, 2016 11:17
@RichardLitt
Copy link
Member

Does this affect the HTTP API at all?

@kevina kevina mentioned this pull request Aug 27, 2016
Merged
@jbenet jbenet mentioned this pull request Aug 28, 2016
Merged
@jbenet
Copy link
Member

jbenet commented Aug 28, 2016

This PR:

  • merged commits that do not pass tests (squash them)
  • merged commits with useless commit messages... (squash them, or write better commit messages)

@jbenet jbenet mentioned this pull request Aug 31, 2016
Closed
58 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@whyrusleeping @RichardLitt @jbenet @Kubuxu