Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove failing blockstore with context test #2857

Merged
merged 1 commit into from
Jun 16, 2016

Commits on Jun 15, 2016

  1. Remove failing blockstore test with context

    Why is it failing:
    process is started, cancel() is called,
    between we satart listening to the channels
    in select statemnet there is race of three things
    that can happent:
     1. Task can complete
     2. Task can start closing <- expected
     3. Task already closed
    
    This race causes failures of the test.
    
    It is basing heavily on race of conditions where
    the task not closing, nor the task is completed
    before channels are being listened.
    
    It is quite impossible to resolve without
    adding bunch of timings in there, which we
    want to avoid, as there is no atomic
    "send message on channel and select" in Golang
    
    License: MIT
    Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
    Kubuxu committed Jun 15, 2016
    Configuration menu
    Copy the full SHA
    5a08e9e View commit details
    Browse the repository at this point in the history