update deps to introduce yamux hang fix #2689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jeromy <why@ipfs.io>
|
LGTM but I haven't looked yet at the libp2p changes. |
|
@Kubuxu the main changes from libp2p here are:
the muxer refactor makes it much easier for us to update the code for each individual muxer without having to update the go-stream-muxer and go-peerstream packages every time |
|
Yup, LGTM |
|
it would be cool if we had a github bot to add the RFM label once a certain set of people comment "LGTM" |
|
@whyrusleeping Who would be the best person to set that up? @lgierth? |
hacdias
pushed a commit
to ipfs/boxo
that referenced
this pull request
Jan 27, 2023
update deps to introduce yamux hang fix This commit was moved from ipfs/kubo@eef8b19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License: MIT
Signed-off-by: Jeromy why@ipfs.io