Docker automatic builds #2308
Merged
Docker automatic builds #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
|
This one's ready -- I'm setting up a cronjob to keep the old image alive for a while |
|
cool, SGTM |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've set up automatic builds of the ipfs/go-ipfs image, but it looks like they prevent the existing jbenet/go-ipfs image from being automatically built. This seems to be due to the integration being done using github services instead of generic webhooks, and docker hub doesn't seem to offer using these webhooks instead. That's why only one automatic build can be triggered by pushing to the repo.
This PR updates all mentions of jbenet/go-ipfs in the repo, but I wanna give the old automated build a grace period, it's used wildly (>300k pulls). I'm not 100% sure how to maintain the automation here, but when in doubt a daily cronjob will do I guess?
Any more thoughts? @jbenet @Luzifer