Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: add PHONY targets and a help message #2249

Merged
merged 1 commit into from
Jan 27, 2016
Merged

Makefile: add PHONY targets and a help message #2249

merged 1 commit into from
Jan 27, 2016

Conversation

atomgardner
Copy link
Contributor

Possibly more to come

@GitCop
Copy link

GitCop commented Jan 27, 2016

There were the following issues with your Pull Request

  • Commit: 45598d6
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

License: MIT
Signed-off-by: Thomas Gardner <tmg@fastmail.com>
@whyrusleeping
Copy link
Member

the circleCI failure appears to be unrelated, but potentially serious.

Aside from that, this looks really good! thanks!! I'm gonna rerun the circleCI test and try for a green, then 🚢

# no-op. try:
# make install
# make test
all: help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 LGTM

whyrusleeping added a commit that referenced this pull request Jan 27, 2016
Makefile: add PHONY targets and a help message
@whyrusleeping whyrusleeping merged commit 04f8d3a into ipfs:master Jan 27, 2016
@atomgardner atomgardner deleted the tmg/build branch March 13, 2016 15:41
@atomgardner atomgardner restored the tmg/build branch March 13, 2016 15:44
@atomgardner atomgardner deleted the tmg/build branch March 13, 2016 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants