More robust version checking

[jedahan]

OK, this checks that the actual value is above 10.9, since this should work on 10.10 as well (though I only tested 10.11).

[GitCop]

There were the following issues with your Pull Request

• Commit: 3419e45
  • Invalid signoff. Commit message must end with
    License: MIT
    Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.

---

This message was auto-generated by https://gitcop.com

[ghost]

LGTM 👍 could you fix the commit signoff?

[rht]

ping @jedahan

[jbenet]

LGTM too. yes needs commit signoff, sorry.

i wish github made it easier for project maintainers to take over PRs, fix them up and merge them.

[rht]

Here is a fork of @jedahan's branch with the signoff "fixed" https://github.com/rht/go-ipfs/tree/smarter-launchd-install. Does this legally count as a signoff?

[jbenet]

Argh no we ofc cannot signoff for other people. I somehow didnt connect the two thoughts there.

Either:

• @jedahan signs off
• we create our own fix / our own commit that achieves the same fix.

[rht]

For the 2nd option, to properly use it, the commit needs to include an attribution[1], e.g.
attribution: https://github.com/jedahan/go-ipfs/commit/3419e45972982cd425c229a1bed18b57bce9f034 by @jedahan is licensed under All Rights Reserved. It is technically not possible to attribute, since "this means that you retain all rights to your source code and that nobody else may reproduce, distribute, or create derivative works from your work" (except for forking in github, as desribed in github's tos) [2].

ref:

1. https://wiki.creativecommons.org/wiki/Best_practices_for_attribution
2. https://help.github.com/articles/open-source-licensing/#what-happens-if-i-dont-choose-a-license

[rht]

(but a fork of go-ipfs should inherit the MIT license by default, and this applies to the commits on it, if they are not explicitly licensed)

[whyrusleeping]

Lets give this three more days, then I'll close it. after than, @rht you want to do something like this and PR it in?

[rht]

@whyrusleeping as, stated, if I were to write a PR based on this PR (i.e. #2246), then there is the attribution issue.

[jedahan]

omg sorry I don't know why this hasn't shown up in my notifications! signing off asap!

[GitCop]

There were the following issues with your Pull Request

• Commit: 1ec5b8c
  • Invalid signoff. Commit message must end with
    License: MIT
    Signed-off-by: .* <.*>

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.

---

This message was auto-generated by https://gitcop.com

[jedahan]

Hmm this should work now

[ghost]

@jedahan happy you made it haha! :):)

[jedahan]

ping, mind merging this, or should I come up with a better solution?

[whyrusleeping]

Okay, looks good! thanks!