gateway: add path prefix for directory listings #1971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Lars Gierth <larsg@systemli.org>
ghost
added
the
| hdr := r.Header["X-IPNS-Original-Path"] | ||
| if len(hdr) > 0 { | ||
| originalUrlPath = hdr[0] | ||
| if hdr := r.Header["X-Ipns-Original-Path"]; len(hdr) > 0 { |
There was a problem hiding this comment.
is this change going to break anyone? or are headers case insensitive?
There was a problem hiding this comment.
net/http seems to convert response header keys to camel-case. I passed X-IPFS-Gateway-Prefix from nginx, and it arrived in the gateway handler as X-Ipfs-Gateway-Prefix. I only changed X-IPNS-Original-Path too for the sake of consistency and avoiding happy accidents.
There was a problem hiding this comment.
Regarding breaking existing stuff by changing the header: it's implementation detail between IPNSHostnameOption and gateway handler
jbenet
added a commit
that referenced
this pull request
Nov 20, 2015
gateway: add path prefix for directory listings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other option would be a config option to rule them all. This one here, lets the reverse proxy signal the path prefix, which allows having the same gateway accessible at multiple paths.
Fixes #1955