Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a --no-pin option to 'ipfs add' #1909

Closed
wants to merge 1 commit into from
Closed

Add a --no-pin option to 'ipfs add' #1909

wants to merge 1 commit into from

Conversation

eminence
Copy link
Contributor

My first PR in go, so please review carefully. Minor nits and style concerns welcome

See #1908 for details on the use-case this tries to solve

@eminence
Add a --no-pin option to 'ipfs add'
bbc2b1f 
See ipfs#1908

Signed-off-by: Andrew Chin <achin@eminence32.net>
@GitCop
Copy link

GitCop commented Oct 28, 2015

There were the following issues with your Pull Request

  • Commit: bbc2b1f
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

Guidelines and a script are available to help. Your feedback on GitCop is welcome on this issue.

This message was auto-generated by https://gitcop.com

@jbenet jbenet added the backlog label Oct 28, 2015
@ghost
Copy link

ghost commented Oct 28, 2015

Maybe this should be --pin and default to true

@eminence
Copy link
Contributor Author

Soon this PR will be closed, and re-opened against the dev0.4.0 branch once #1778 is merged.

@ghost
Copy link

ghost commented Oct 28, 2015

No need to open a new PR, you can git push -f to the same branch and it'll update

@whyrusleeping
Copy link
Member

@lgierth github doesnt let you change what branch your PR is based off of, this PR needs to be made on dev0.4.0 after the other PR gets merged into it.

@ghost
Copy link

ghost commented Oct 28, 2015

Oh I see. I was thinking they wanted to wait until dev0.4.0 is merged into master.

eminence added a commit to eminence/go-ipfs that referenced this pull request Nov 2, 2015
@eminence
Add a --no-pin option to ipfs add
2a978c6 
Implements a solution for ipfs#1908

This PR replaces ipfs#1909

License: MIT
Signed-off-by: Andrew Chin <achin@eminence32.net>
@eminence eminence mentioned this pull request Nov 2, 2015
Merged
@eminence
Copy link
Contributor Author

eminence commented Nov 2, 2015

Please see #1931 instead

@eminence eminence closed this Nov 2, 2015
@jbenet jbenet removed the backlog label Nov 2, 2015
eminence added a commit to eminence/go-ipfs that referenced this pull request Nov 12, 2015
@eminence
Add a --pin option to ipfs add (allowing --pin=false)
b4c4591 
Implements a solution for ipfs#1908

This PR replaces ipfs#1909

License: MIT
Signed-off-by: Andrew Chin <achin@eminence32.net>
whyrusleeping pushed a commit that referenced this pull request Dec 22, 2015
@eminence @whyrusleeping
Add a --pin option to ipfs add (allowing --pin=false)
1b03ca0 
Implements a solution for #1908

This PR replaces #1909

License: MIT
Signed-off-by: Andrew Chin <achin@eminence32.net>
whyrusleeping pushed a commit that referenced this pull request Dec 28, 2015
@eminence @whyrusleeping
Add a --pin option to ipfs add (allowing --pin=false)
1fbdfa2 
Implements a solution for #1908

This PR replaces #1909

License: MIT
Signed-off-by: Andrew Chin <achin@eminence32.net>
whyrusleeping pushed a commit that referenced this pull request Jan 12, 2016
@eminence @whyrusleeping
Add a --pin option to ipfs add (allowing --pin=false)
b6f28da 
Implements a solution for #1908

This PR replaces #1909

License: MIT
Signed-off-by: Andrew Chin <achin@eminence32.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eminence @GitCop @whyrusleeping @jbenet