Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow patch add-link to add at a path #1404

Merged
merged 1 commit into from
Jun 20, 2015
Merged

allow patch add-link to add at a path #1404

merged 1 commit into from
Jun 20, 2015

Conversation

whyrusleeping
Copy link
Member

Lets patch do bubbling up

License: MIT
Signed-off-by: Jeromy jeromyj@gmail.com

@whyrusleeping
allow patch add-link to add at a path
d585e20 
License: MIT
Signed-off-by: Jeromy <jeromyj@gmail.com>
@whyrusleeping whyrusleeping added the status/in-progress In progress label Jun 20, 2015
@jbenet
Copy link
Member

jbenet commented Jun 20, 2015

LGTM! RFM

jbenet
jbenet reviewed Jun 20, 2015
View reviewed changes
test/sharness/t0051-object.sh
EMPTY=$(ipfs object new unixfs-dir) &&
ONE=$(ipfs object patch $EMPTY add-link b $EMPTY) &&
TWO=$(ipfs object patch $EMPTY add-link a $ONE) &&
ipfs object patch $TWO add-link a/b/c $FILE > multi_patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice test

whyrusleeping added a commit that referenced this pull request Jun 20, 2015
@whyrusleeping
Merge pull request #1404 from ipfs/feat/patch-path
7d254ae 
allow patch add-link to add at a path
@whyrusleeping whyrusleeping merged commit 7d254ae into master Jun 20, 2015
@whyrusleeping whyrusleeping removed the status/in-progress In progress label Jun 20, 2015
wking added a commit that referenced this pull request Jun 20, 2015
@wking
test/sharness/t0051-object.sh: Collect OUTPUT tests together
3f90ef4 
Pull the independent multi-layer test added in d585e20 (allow patch
add-link to add at a path, 2015-06-19, #1404) out into a separate
block, so it's easier to read the single-layer tests that share the
OUTPUT variable.

License: MIT
Signed-off-by: W. Trevor King <wking@tremily.us>
@jbenet jbenet mentioned this pull request Jun 22, 2015
Closed
55 tasks
@Kubuxu Kubuxu deleted the feat/patch-path branch May 13, 2016 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whyrusleeping @jbenet