fix offline full path resolution bug #1275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whyrusleeping
force-pushed
the
fix/resolution
branch
from
1babd9d
to
60ac591
Compare
|
Minor comments on the pathresolver.go change, but I'm ok if this lands
with just the "/ipns" -> "/ipns/" change.
Tests look good to me.
|
|
Rerolled 60ac591 looks good to me.
|
|
merging now, low risk, high impact. |
whyrusleeping
added a commit
that referenced
this pull request
May 21, 2015
fix offline full path resolution bug
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also added a basic offline sharness test to verify