Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use ipfs-webui@4.3.2 #10523

Merged
merged 2 commits into from
Sep 24, 2024
Merged

feat: use ipfs-webui@4.3.2 #10523

merged 2 commits into from
Sep 24, 2024

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Sep 23, 2024 •
edited by lidel
Loading

@lidel lidel added the skip/changelog This change does NOT require a changelog entry label Sep 23, 2024
lidel
lidel requested changes Sep 23, 2024
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think things with ipfs/ipfs-webui#2266 are worse than I thought, it IS a regression because local Kubo is not used at all by IPLD Explorer.

Just try opening IPLD Explorer's Wikipedia example on empty browser profile (without Helia having a block in cache):

v4.3.0 only hits local Kubo v4.3.1 hits random gateways and not local Kubo
old-2024-09-23_19-42 new-2024-09-23_19-44

So we can't update ipfs-webui without fixing ipfs/ipfs-webui#2266 first.

@lidel lidel added the status/blocked Unable to be worked further until needs are met label Sep 23, 2024
@SgtPooki
Copy link
Member Author

I will work on that bug asap

@lidel lidel changed the title feat: use ipfs-webui@4.3.1 feat: use ipfs-webui@4.3.2 Sep 24, 2024
lidel
lidel reviewed Sep 24, 2024
View reviewed changes
core/corehttp/webui.go Outdated Show resolved Hide resolved
lidel
lidel approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switched to v4.3.2 lgtm, thank you @SgtPooki

@lidel lidel merged commit ce23fc7 into master Sep 24, 2024
14 checks passed
@lidel lidel deleted the SgtPooki-patch-1 branch September 24, 2024 21:26
@lidel lidel mentioned this pull request Sep 24, 2024
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
skip/changelog This change does NOT require a changelog entry status/blocked Unable to be worked further until needs are met
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SgtPooki @lidel