feat: run AutoNAT V2 service in addition to V1 #10468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lidel
force-pushed
the
feat/enable-autonatv2-service
branch
from
eb1d184
to
8a957aa
Compare
This was referenced Aug 6, 2024
Closed
Part of #10091 We include a flag that allows shutting down V2 in case there are issues with it.
lidel
force-pushed
the
feat/enable-autonatv2-service
branch
from
db3bc16
to
1108d4e
Compare
lidel
commented
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #10091 proposed by @sukunrt.
It enables V2 (libp2p/specs#538) alongside V1, and adds configuration option that allows disabling V2 (just in case).
TODO
EnableAutoNATv2in addition to V1 by default#10436