Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test failure: mux_test.go:TestStopping #99

Closed
btc opened this issue Sep 22, 2014 · 1 comment
Closed

test failure: mux_test.go:TestStopping #99

btc opened this issue Sep 22, 2014 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@btc
Copy link
Contributor

btc commented Sep 22, 2014

https://gist.github.com/perfmode/3498c372c5ffde915406

@btc btc added the kind/bug A bug in existing code (including security flaws) label Sep 22, 2014
@whyrusleeping
Copy link
Member

Cant repro, closing.

@ghost ghost mentioned this issue Oct 7, 2021
3 tasks
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
Before, we could end up (e.g.):

1. Creating two connections (both sides connect at the same time).
2. Try to test with the first one.
3. The first connection dies.
4. Get a stream reset and think that the other side doesn't support the DHT
protocol.

We tried to fix this by checking for an EOF. Unfortunately, reset streams don't
return EOFs.

This commit also simplifies peer tracking (and saves a bit of memory).

fixes ipfs#99
@aschmahmann aschmahmann mentioned this issue Dec 1, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants