Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goroutine leak #6627

Closed
sidenaio opened this issue Sep 5, 2019 · 0 comments · Fixed by #6629
Closed

Goroutine leak #6627

sidenaio opened this issue Sep 5, 2019 · 0 comments · Fixed by #6629
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@sidenaio
Copy link

sidenaio commented Sep 5, 2019

Version information:

go-ipfs version: 0.4.22

Description:

We use ipfs as a library. Our application needs a lot of cid calculations. We use UnixfsAPI.Add with HashOnly=true option. It causes a goroutine leak. In this case UnixfsAPI.Add creates a new IpfsNode that creates pstore.Peerstore and pstore.AddrBook. pstore.AddrBook starts goroutine in its constructor and never stops one. Looks like pstore.Peerstore.Close is never invoked.
@sidenaio sidenaio added the kind/bug A bug in existing code (including security flaws) label Sep 5, 2019
Stebalien added a commit that referenced this issue Sep 6, 2019
@Stebalien
fix: close peerstore on stop
40f6ecf 
fixes #6627
@Stebalien Stebalien mentioned this issue Sep 6, 2019
Merged
Stebalien added a commit that referenced this issue Sep 6, 2019
@Stebalien
fix: close peerstore on stop
9f1f958 
fixes #6627
Stebalien added a commit that referenced this issue Jan 17, 2020
@Stebalien
fix: close peerstore on stop
d72a66a 
fixes #6627
Stebalien added a commit that referenced this issue Jan 17, 2020
@Stebalien
fix: close peerstore on stop
6131b7f 
fixes #6627
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
fix: close peerstore on stop
a19eb3b 
fixes ipfs#6627
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
fix: close peerstore on stop
e31a163 
fixes ipfs#6627
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
fix: close peerstore on stop
b7ad87c 
fixes ipfs#6627
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
fix: close peerstore on stop
2f454b4 
fixes ipfs#6627
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
fix: close peerstore on stop
832de46 
fixes ipfs#6627
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
fix: close peerstore on stop
6cff810 
fixes ipfs#6627
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
fix: close peerstore on stop
601a57e 
fixes ipfs#6627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: close peerstore on stop ipfs/kubo
1 participant
@sidenaio