Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GC and MFS are not safe #6113

Open
Stebalien opened this issue Mar 21, 2019 · 2 comments · May be fixed by #8447
Open

GC and MFS are not safe #6113

Stebalien opened this issue Mar 21, 2019 · 2 comments · May be fixed by #8447
Assignees
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

Stebalien commented Mar 21, 2019

We don't hold any form of GC lock while adding files to MFS.

[@schomatis] Possible related items to revisit after applying the MFS global lock:

@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Mar 21, 2019
@jaccarmac
Copy link

Is there a way to work around this short of manually pinning everything added to the root of MFS?

@Kubuxu
Copy link
Member

Kubuxu commented Jun 3, 2019

@jaccarmac after a file is in MFS it is safe.
GC and MFS operations at the same time are currently not safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
No open projects
Status: 🛑 Blocked
Development

Successfully merging a pull request may close this issue.

5 participants