config/show should be application/json #5335
Labels
kind/bug
A bug in existing code (including security flaws)
Comments
Stebalien
added a commit
that referenced
this issue
Aug 6, 2018
This doesn't change there CLI output, it just means that the server responds with a JSON output by default. fixes #5335 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Stebalien
added a commit
that referenced
this issue
May 30, 2019
This doesn't change there CLI output, it just means that the server responds with a JSON output by default. fixes #5335 License: MIT Signed-off-by: Steven Allen <steven@stebalien.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Right now, go-ipfs HTTP API is responding to config?arg=key with:
But for
config/show, we have:Since it's a JSON object, doesn't it make sense to change the Content Type to
application/jsononconfig/show?Ref.: ipfs-inactive/js-ipfs-http-client#822
The text was updated successfully, but these errors were encountered: