Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipfs swarm connect /ipfs/QmId fails #5102

Closed
Stebalien opened this issue Jun 9, 2018 · 1 comment
Closed

ipfs swarm connect /ipfs/QmId fails #5102

Stebalien opened this issue Jun 9, 2018 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

When we don't already know a peer's address, ipfs swarm connect /ipfs/QmId always fails. This is because we:

  1. Record "" as the peer's address (maddr.Transport() should return nil when there is no transport ipfs-inactive/go-ipfs-addr#4)
  2. Never search for addresses if we think we know a peer's address RoutedHost should search for addrs when none of the addrs we tried worked libp2p/go-libp2p#351.
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Jun 9, 2018
@whyrusleeping
Copy link
Member

good catch

djdv pushed a commit that referenced this issue Jun 27, 2018
@Stebalien @djdv
make ipfs swarm connect /ipfs/QmId work
f40d0b4 
fixes #5102

Also, allow specifying multiple addresses for a single peer.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
@Stebalien
make ipfs swarm connect /ipfs/QmId work
25a763f 
fixes ipfs#5102

Also, allow specifying multiple addresses for a single peer.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
@Stebalien
go-ipfs-config: make ipfs swarm connect /ipfs/QmId work
514edce 
fixes ipfs#5102

Also, allow specifying multiple addresses for a single peer.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Mar 4, 2022
@Stebalien
go-ipfs-config: make ipfs swarm connect /ipfs/QmId work
019e7b2 
fixes ipfs#5102

Also, allow specifying multiple addresses for a single peer.

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Stebalien @whyrusleeping