Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MFS: Race when reading node and taking read/write lock #4514

Closed
Stebalien opened this issue Dec 21, 2017 · 0 comments
Closed

MFS: Race when reading node and taking read/write lock #4514

Stebalien opened this issue Dec 21, 2017 · 0 comments

Comments

@Stebalien
Copy link
Member

We currently read the node (under the node lock), then take the read/write lock. However, a racing thread could also read the node, then take the write lock before us, update the node, and write it back. We'll then take the read (or write) lock and see the old node, not the new one.
Stebalien added a commit that referenced this issue Dec 21, 2017
@Stebalien
mfs: take the read/write lock *before* extracting the node.
b051842 
Otherwise, it could be exchanged out from under us!

fixes #4514

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien mentioned this issue Dec 21, 2017
Closed
Stebalien added a commit that referenced this issue Dec 21, 2017
@Stebalien
mfs: take the read/write lock *before* extracting the node.
e68ef05 
Otherwise, it could be exchanged out from under us!

fixes #4514

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@Stebalien Stebalien mentioned this issue Dec 21, 2017
Closed
Stebalien added a commit that referenced this issue Dec 21, 2017
@Stebalien
mfs: take the read/write lock *before* extracting the node.
a5ed5f3 
Otherwise, it could be exchanged out from under us!

fixes #4514

License: MIT
Signed-off-by: Steven Allen <steven@stebalien.com>
@schomatis schomatis mentioned this issue Mar 2, 2018
Closed
@schomatis schomatis mentioned this issue Dec 19, 2018
Closed
4 tasks
@nitishm nitishm mentioned this issue Dec 31, 2018
Merged
@Stebalien Stebalien mentioned this issue Jan 8, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] MFS improvements ipfs/kubo
[WIP] MFS improvements
1 participant
@Stebalien