Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ugly output when killing a command #3785

Closed
whyrusleeping opened this issue Mar 15, 2017 · 1 comment · Fixed by ipfs/go-ipfs-cmds#137
Closed

Fix ugly output when killing a command #3785

whyrusleeping opened this issue Mar 15, 2017 · 1 comment · Fixed by ipfs/go-ipfs-cmds#137
Assignees
@Stebalien
Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature

Comments

@whyrusleeping
Copy link
Member

Killing an ipfs command with ctrl+c prints this ugly error message:

00:01:48.015 ERROR commands/h: net/http: request canceled client.go:247
Error: net/http: request canceled

I know that the request was canceled. I canceled it..
@Kubuxu Kubuxu added kind/enhancement A net-new feature or improvement to an existing feature status/deferred Conscious decision to pause or backlog status/ready Ready to be worked help wanted Seeking public contribution on this issue and removed status/deferred Conscious decision to pause or backlog labels Mar 15, 2017
@whyrusleeping whyrusleeping added status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Oct 17, 2017
@Stebalien
Copy link
Member

This is now slightly better. The client just prints out Error: context canceled (no line numbers, etc.).

Stebalien added a commit to ipfs/go-ipfs-cmds that referenced this issue Dec 7, 2018
@Stebalien
print a nicer error on timeout/cancel
af847ec 
*Don't* say "context canceled". Just say "canceled".

fixes ipfs/kubo#3785
@Stebalien Stebalien mentioned this issue Dec 7, 2018
Merged
@ghost ghost assigned Stebalien Dec 7, 2018
@ghost ghost added status/in-progress In progress and removed status/deferred Conscious decision to pause or backlog labels Dec 7, 2018
@ghost ghost removed the status/in-progress In progress label Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stebalien Stebalien

Labels
help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

print a nicer error on timeout/cancel ipfs/go-ipfs-cmds
3 participants
@Stebalien @whyrusleeping @Kubuxu