tar cat should return appropriate headers

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>

commands/http/handler.go

@@ -262,6 +262,10 @@ func sendResponse(w http.ResponseWriter, r *http.Request, res cmds.Response, req
 		h.Set(channelHeader, "1")
 	}
 
+	if len(res.Request().Path()) == 2 && res.Request().Path()[0] == "tar" {
+		mime = "application/x-tar"
+	}
+
 	// catch-all, set to text as default
 	if mime == "" {
 		mime = "text/plain"

test/sharness/t0211-tar-headers.sh

@@ -0,0 +1,42 @@
+#!/bin/sh
+
+test_description="Test tar cat headers"
+
+test_tar_cat_headers() {
+    mkdir foo &&
+    random 10000 > foo/a &&
+    random 12345 > foo/b &&
+    mkdir foo/bar &&
+    random 5432 > foo/bar/baz &&
+    ln -s ../a foo/bar/link &&
+    echo "exit" > foo/script &&
+    chmod +x foo/script
+    tar cf files.tar foo/
+    TAR_HASH=$(ipfs tar add files.tar)
+    mkdir output &&
+    ipfs tar cat $TAR_HASH > output/out.tar
+}
+
+.   lib/test-lib.sh
+
+test_init_ipfs
+test_tar_cat_headers
+test_launch_ipfs_daemon
+
+gwport=$GWAY_PORT
+apiport=$API_PORT
+
+# Gateway
+
+# HTTP GET Request
+test_expect_success "GET to Gateway succeeds" '
+    curl -svX GET "http://127.0.0.1:$gwport/api/v0/tar/cat?arg=$TAR_HASH" 2>curl_output
+'
+# GET Response from Gateway should contain correct content type
+test_expect_success "GET response for Gateway resource looks good" '
+    grep "application:x-tar" curl_output
+'
+
+test_kill_ipfs_daemon
+
+test_done