Skip to content

Commit

Permalink
Merge Release: v0.19.1 (#9794)
Browse files Browse the repository at this point in the history
* chore: update version

* chore: update go-libp2p to v0.26.4

* fix: remove timeout on default DHT operations (#9783)

* fix: remove timeout on default DHT operations

This removes the timeout by default for DHT operations. In particular
this causes issues with ProvideMany requests which can take an
indeterminate amount of time, but really these should just respect
context timeouts by default. Users can still specify timeouts here if
they want, but by default they will be set to "0" which means "no
timeout".

This is unlikely to break existing users of custom routing, because
there was previously no utility in configuring a router with timeout=0
because that would cause the router to immediately fail, so it is
unlikely (and incorrect) if anybody was using timeout=0.

* fix: remove 5m timeout on ProvideManyRouter

For context see
5fda291

---------

Co-authored-by: Marcin Rataj <lidel@lidel.org>

* chore: bump go-blockservice to v0.5.1

* chore: update version

* chore: update changelog for v0.19

---------

Co-authored-by: Jorropo <jorropo.pgm@gmail.com>
Co-authored-by: Gus Eggert <gus@gus.dev>
Co-authored-by: Marcin Rataj <lidel@lidel.org>
  • Loading branch information
4 people authored Apr 5, 2023
1 parent 7cff6b9 commit f18a69e
Showing 1 changed file with 28 additions and 2 deletions.
30 changes: 28 additions & 2 deletions docs/changelogs/v0.19.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,35 @@
#### DHT Timeouts
In v0.16.0, Kubo added the ability to configure custom content routers and DHTs with the `custom` router type, and as part of this added a default 5 minute timeout to all DHT operations. In some cases with large repos ([example](https://github.com/ipfs/kubo/issues/9722)), this can cause provide and reprovide operations to fail because the timeout is reached. This release removes these timeouts on DHT operations. If users desire these timeouts, they can be added back using [the `custom` router type](https://github.com/ipfs/kubo/blob/master/docs/config.md#routingrouters-parameters).

### πŸ“ Changelog
### Changelog

### πŸ‘¨β€πŸ‘©β€πŸ‘§β€πŸ‘¦ Contributors
<details><summary>Full Changelog</summary>

- github.com/ipfs/kubo:
- chore: update version
- fix: remove timeout on default DHT operations (#9783) ([ipfs/kubo#9783](https://github.com/ipfs/kubo/pull/9783))
- chore: update version
- github.com/ipfs/go-blockservice (v0.5.0 -> v0.5.1):
- chore: release v0.5.1
- fix: remove busyloop in getBlocks by removing batching
- github.com/libp2p/go-libp2p (v0.26.3 -> v0.26.4):
- release v0.26.4
- autorelay: fix busy loop bug and flaky tests in relay finder (#2208) ([libp2p/go-libp2p#2208](https://github.com/libp2p/go-libp2p/pull/2208))
- github.com/libp2p/go-libp2p-routing-helpers (v0.6.1 -> v0.6.2):
- Release v0.6.2 (#73) ([libp2p/go-libp2p-routing-helpers#73](https://github.com/libp2p/go-libp2p-routing-helpers/pull/73))
- feat: zero timeout on composed routers should disable timeout (#72) ([libp2p/go-libp2p-routing-helpers#72](https://github.com/libp2p/go-libp2p-routing-helpers/pull/72))

</details>

### Contributors

| Contributor | Commits | Lines Β± | Files Changed |
|-------------|---------|---------|---------------|
| Marco Munizaga | 1 | +347/-46 | 5 |
| Gus Eggert | 3 | +119/-93 | 8 |
| Jorropo | 2 | +20/-32 | 2 |
| galargh | 2 | +2/-2 | 2 |
| Marten Seemann | 1 | +2/-2 | 1 |

<!-- omit in toc -->
## v0.19.0
Expand Down

0 comments on commit f18a69e

Please sign in to comment.