test: false for isHTTPSRequest

As suggested in #7847 (comment)
ipfs · Jan 7, 2021 · 88dd257 · 88dd257
1 parent 09178aa
commit 88dd257
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/core/corehttp/hostname.go b/core/corehttp/hostname.go
@@ -414,7 +414,7 @@ func toDNSLabel(rootID string, rootCID cid.Cid) (dnsCID string, err error) {
 }
 
 // Returns true if HTTP request involves TLS certificate.
-// See https://github.com/ipfs/in-web-browsers/issues/169 to uderstand how it
+// See https://github.com/ipfs/in-web-browsers/issues/169 to understand how it
 // impacts DNSLink websites on public gateways.
 func isHTTPSRequest(r *http.Request) bool {
 	// X-Forwarded-Proto if added by a reverse proxy

diff --git a/core/corehttp/hostname_test.go b/core/corehttp/hostname_test.go
@@ -106,13 +106,18 @@ func TestIsHTTPSRequest(t *testing.T) {
 	httpsRequest := httptest.NewRequest("GET", "https://https-request-stub.example.com", nil)
 	httpsProxiedRequest := httptest.NewRequest("GET", "http://proxied-https-request-stub.example.com", nil)
 	httpsProxiedRequest.Header.Set("X-Forwarded-Proto", "https")
+	httpProxiedRequest := httptest.NewRequest("GET", "http://proxied-http-request-stub.example.com", nil)
+	httpProxiedRequest.Header.Set("X-Forwarded-Proto", "http")
+	oddballRequest := httptest.NewRequest("GET", "foo://127.0.0.1:8080", nil)
 	for _, test := range []struct {
 		in  *http.Request
 		out bool
 	}{
 		{httpRequest, false},
 		{httpsRequest, true},
 		{httpsProxiedRequest, true},
+		{httpProxiedRequest, false},
+		{oddballRequest, false},
 	} {
 		out := isHTTPSRequest(test.in)
 		if out != test.out {