Skip to content

Commit

Permalink
fix: ipfs get panic with empty API call
Browse files Browse the repository at this point in the history
License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
  • Loading branch information
Kubuxu committed Mar 9, 2017
1 parent 0d66404 commit 66cc2f2
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
5 changes: 5 additions & 0 deletions core/commands/get.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,11 @@ may also specify the level of compression by specifying '-l=<1-9>'.
return err
},
Run: func(req cmds.Request, res cmds.Response) {
if len(req.Arguments()) == 0 {
res.SetError(errors.New("not enough arugments provided"), cmds.ErrClient)
return
}

cmplvl, err := getCompressOptions(req)
if err != nil {
res.SetError(err, cmds.ErrClient)
Expand Down
9 changes: 8 additions & 1 deletion test/sharness/t0090-get.sh
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ test_get_fail() {
'

test_expect_success "ipfs get fails" '
test_expect_code 1 ipfs get QmaGidyrnX8FMbWJoxp8HVwZ1uRKwCyxBJzABnR1S2FVUr
test_expect_code 1 ipfs get QmaGidyrnX8FMbWJoxp8HVwZ1uRKwCyxBJzABnR1S2FVUr
'
}

Expand All @@ -154,6 +154,13 @@ test_get_fail
# should work online
test_launch_ipfs_daemon
test_get_cmd

test_expect_success "empty request to get doesn't panic and returns error" '
curl "http://$API_ADDR/api/v0/get" > curl_out || true &&
grep "not enough arugments provided" curl_out
'
test_kill_ipfs_daemon

test_done

0 comments on commit 66cc2f2

Please sign in to comment.