Skip to content

Commit

Permalink
Merge pull request #3421 from ipfs/feat/test/go-fmt
Browse files Browse the repository at this point in the history
Add check if go code is formatted
  • Loading branch information
whyrusleeping authored Nov 25, 2016
2 parents 0980bf6 + 21c7ec8 commit 4511a4a
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 3 deletions.
7 changes: 5 additions & 2 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,16 @@ PHONY += go_check deps vendor install build nofuse clean uninstall

test: test_expensive

test_short: build test_go_short test_sharness_short
test_short: test_go_fmt build test_go_short test_sharness_short

test_expensive: build test_go_expensive test_sharness_expensive windows_build_check
test_expensive: test_go_fmt build test_go_expensive test_sharness_expensive windows_build_check

test_3node:
$(MAKE) -C test/3nodetest

test_go_fmt:
bin/test-go-fmt

test_go_short:
$(go_test) -test.short ./...

Expand Down
15 changes: 15 additions & 0 deletions bin/test-go-fmt
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
#!/usr/bin/env bash
set -euo pipefail
T="$(mktemp)"
find . -name '*.go' | xargs gofmt -l > "$T"

if [ -n "$(cat $T)" ]; then
echo "Following Go code is not formatted."
echo "-----------------------------------"
cat "$T"
echo "-----------------------------------"
echo "Run 'go fmt ./...' in your source directory"
rm -f "$T"
exit 1
fi
rm -f "$T"
1 change: 0 additions & 1 deletion unixfs/io/pbdagreader.go
Original file line number Diff line number Diff line change
Expand Up @@ -249,4 +249,3 @@ func (dr *pbDagReader) Seek(offset int64, whence int) (int64, error) {
return 0, errors.New("invalid whence")
}
}

0 comments on commit 4511a4a

Please sign in to comment.