Merge pull request #4533 from ipfs/nit/bitswap-loggable

only construct bitswap event loggable if necessary
ipfs · Dec 31, 2017 · 026d873 · 026d873
2 parents 72714b6 + 914e653
commit 026d873
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/exchange/bitswap/workers.go b/exchange/bitswap/workers.go
@@ -59,11 +59,13 @@ func (bs *Bitswap) taskWorker(ctx context.Context, id int) {
 				if !ok {
 					continue
 				}
-				log.Event(ctx, "Bitswap.TaskWorker.Work", logging.LoggableMap{
-					"ID":     id,
-					"Target": envelope.Peer.Pretty(),
-					"Block":  envelope.Block.Cid().String(),
-				})
+				log.Event(ctx, "Bitswap.TaskWorker.Work", logging.LoggableF(func() map[string]interface{} {
+					return logging.LoggableMap{
+						"ID":     id,
+						"Target": envelope.Peer.Pretty(),
+						"Block":  envelope.Block.Cid().String(),
+					}
+				}))
 
 				// update the BS ledger to reflect sent message
 				// TODO: Should only track *useful* messages in ledger