feat: remove default key size and upgrade go-ipfs-dep #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`go-ipfs@0.5.0` doesn't support keys < 2048 so let the implementation decide what the default key size should be The value is overridable as before by setting `ipfsOptions.init.bits` in the node setup.
achingbrain
force-pushed
the
fix/remove-default-key-size
branch
from
0ebe409
to
db0299d
Compare
achingbrain
changed the title
achingbrain
changed the title
1 task
hugomrdias
approved these changes
Apr 29, 2020
hugomrdias
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-ipfs@0.5.0doesn't support keys < 2048 so let the implementation decide what the default key size should be.The value is overridable as before by setting
ipfsOptions.init.bitsin the node setup.