Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Only show connected addrs for peers in swarm.peers #960

Merged
merged 10 commits into from
Sep 1, 2017
Merged

Only show connected addrs for peers in swarm.peers #960

merged 10 commits into from
Sep 1, 2017

Conversation

victorb
Copy link
Member

@victorb victorb commented Aug 26, 2017 •
edited
Loading

No description provided.

@victorb victorb mentioned this pull request Aug 26, 2017
Merged
daviddias
daviddias reviewed Aug 26, 2017
View reviewed changes
src/core/components/swarm.js Outdated
addr: addr,
peer: peer
addr: connectedAddr,
peer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please keep using the notation peer: peer.

@daviddias daviddias added the status/in-progress In progress label Aug 28, 2017
@daviddias
Copy link
Member

@victorbjelkholm what's missing to get his merged?

@victorb
Copy link
Member Author

victorb commented Sep 1, 2017

@diasdavid needs ipfs-inactive/interface-js-ipfs-core#150 to be merged + released to have the tests, otherwise this PR is ready. Just pushed update removing the object literal shorthand.

@daviddias
Copy link
Member

@victorbjelkholm seems that it is failing:

          Shows connected peers only once
Swarm listening on /ip4/127.0.0.1/tcp/37115/ipfs/QmfC6YXRVc6PHVtWVTWnbrFKzNDrYPBHEweq8MYrEsoN1q
              1) Connecting two peers with one address each
Swarm listening on /ip4/127.0.0.1/tcp/6543/ipfs/QmdfdpQjfrp6gi3wJCBQ2TpNmxgnkwTmQ2w7BsqwjD8vin
Swarm listening on /ip4/127.0.0.1/tcp/6544/ipfs/QmdfdpQjfrp6gi3wJCBQ2TpNmxgnkwTmQ2w7BsqwjD8vin
              2) Connecting two peers with two addresses each

@daviddias
Copy link
Member

rebased master onto this branch

@victorb victorb changed the title Only show connected addrs for peers in swarm.peers [WIP] Only show connected addrs for peers in swarm.peers Sep 1, 2017
@daviddias
Copy link
Member

@victorbjelkholm tests pass locally but not in CI

image

@daviddias daviddias merged commit d939323 into master Sep 1, 2017
@daviddias daviddias deleted the swarm-connected-peers branch September 1, 2017 13:09
@victorb victorb mentioned this pull request Sep 1, 2017
Closed
@snyk-bot snyk-bot mentioned this pull request Oct 10, 2021
Open
This was referenced Jun 23, 2023
Open
Open
Open
Open
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias left review comments

Assignees

@victorb victorb

Labels
status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@victorb @daviddias