fix(examples): Ensure started prior to adding file #912

bitspill · 2017-07-15T03:10:57Z

No description provided.

daviddias · 2017-07-15T09:53:28Z

examples/transfer-files/public/js/app.js

@@ -114,6 +114,10 @@ function onDrop (event) {
  onDragExit()
  $errors.className = 'hidden'
  event.preventDefault()
+  if (!node) {
+    onError("IPFS must be started before files can be added")


This is causing a linting error, could you change to single quotes, please?

https://travis-ci.org/ipfs/js-ipfs/jobs/253836140#L4278

daviddias · 2017-07-15T11:11:58Z

thanks @bitspill :)

Better error reporting by detecting `Content-Type` of the response and not attempting to parse JSON for non-`application/json` responses. resolves ipfs#912 resolves ipfs#1000 closes ipfs#1001 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>

daviddias approved these changes Jul 15, 2017

View reviewed changes

daviddias suggested changes Jul 15, 2017

View reviewed changes

fix(examples): Ensure started prior to adding file

eb6a3d9

bitspill force-pushed the patch-1 branch from 2ea1186 to eb6a3d9 Compare July 15, 2017 10:03

daviddias approved these changes Jul 15, 2017

View reviewed changes

daviddias merged commit 69162e8 into ipfs:master Jul 15, 2017

dryajov pushed a commit that referenced this pull request Sep 1, 2017

docs(examples): Ensure started prior to adding file (#912)

663e592

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(examples): Ensure started prior to adding file #912

fix(examples): Ensure started prior to adding file #912

bitspill commented Jul 15, 2017

daviddias Jul 15, 2017

bitspill Jul 15, 2017

daviddias commented Jul 15, 2017

fix(examples): Ensure started prior to adding file #912

fix(examples): Ensure started prior to adding file #912

Conversation

bitspill commented Jul 15, 2017

daviddias Jul 15, 2017

Choose a reason for hiding this comment

bitspill Jul 15, 2017

Choose a reason for hiding this comment

daviddias commented Jul 15, 2017