This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: pull-stream-to-stream replaced with duplex stream #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/core/components/files.js
Outdated
| _read () { | ||
| this._pullStream(null, (err, data) => { | ||
| if (err) { | ||
| if (err instanceof Error) { |
There was a problem hiding this comment.
what about true for end?
There was a problem hiding this comment.
instead of calling it err I'm now calling it end.
daviddias
approved these changes
Mar 24, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stream-to-duplex-stream ends the stream immediately when
classicStream.endis called.Since now the unifxfs addStream end happens asynchronously, this was ending the stream prematurely, before it had the chance to emit everything.