Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: add CLI support for different hash func and type #748

Merged
merged 1 commit into from
Jan 31, 2017

Conversation

daviddias
Copy link
Member

@kumavis I've imported the changes you made on the DAG API PR -- #636 -- to here, but getting this error:

  1) cli --all block with daemon off (requiring js-ipfs core directly) put with flags, format and mhtype:

      AssertionError: expected 'cZxfGwVjp1wDnUowKQ5sR6zEQubxB8Dys2dMZ4t8a3dnse' to deeply equal 'z43AaGF23fmvRnDP56Ub9WcJCfzSfqtmzNCCvmz5eudT8dtdCDS'
      + expected - actual

      -cZxfGwVjp1wDnUowKQ5sR6zEQubxB8Dys2dMZ4t8a3dnse
      +z43AaGF23fmvRnDP56Ub9WcJCfzSfqtmzNCCvmz5eudT8dtdCDS

      at ipfs.then (test/cli/test-block.js:21:24)
      at process._tickDomainCallback (internal/process/next_tick.js:129:7)

Was this working for you before?

@daviddias daviddias added the status/in-progress In progress label Jan 31, 2017
@kumavis
Copy link
Contributor

kumavis commented Jan 31, 2017

yeah was working before -- not sure whats wrong here

@kumavis
Copy link
Contributor

kumavis commented Jan 31, 2017

@diasdavid the hash matches the eth-block test z43AaGF23fmvRnDP56Ub9WcJCfzSfqtmzNCCvmz5eudT8dtdCDS

but the test message/label doesnt match?

@daviddias
Copy link
Member Author

just fixed it, the if clause was wrong because when I migrated, I kept the option to do CIDv0 too and introduced a bug, now it is good :)

@daviddias daviddias merged commit a6c522f into master Jan 31, 2017
@daviddias daviddias deleted the feat/update-block-api branch January 31, 2017 19:44
@daviddias daviddias removed the status/in-progress In progress label Jan 31, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants